Github user cclauss commented on a diff in the pull request:
https://github.com/apache/spark/pull/20838#discussion_r204094593
--- Diff: dev/create-release/releaseutils.py ---
@@ -149,7 +152,11 @@ def get_commits(tag):
if not is_valid_author(author):
author = github_username
# Guard against special characters
- author = unidecode.unidecode(unicode(author, "UTF-8")).strip()
+ try: # Python 2
+ author = unicode(author, "UTF-8")
+ except NameError: # Python 3
+ author = str(author)
+ author = unidecode.unidecode(author).strip()
--- End diff --
Yes... My other worry in Py2 would be if
[__sys.setdefaultencoding()__](https://docs.python.org/2/library/sys.html#sys.setdefaultencoding)
was set to somthing other that utf-8. That method was also thankfully dropped
in Py3.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
