Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/21837#discussion_r204300978
--- Diff:
external/avro/src/main/scala/org/apache/spark/sql/avro/AvroFileFormat.scala ---
@@ -133,8 +134,7 @@ private[avro] class AvroFileFormat extends FileFormat
with DataSourceRegister {
job.getConfiguration.set(AvroJob.CONF_OUTPUT_CODEC,
DataFileConstants.SNAPPY_CODEC)
case "deflate" =>
- val deflateLevel = spark.conf.get(
- AVRO_DEFLATE_LEVEL, Deflater.DEFAULT_COMPRESSION.toString).toInt
--- End diff --
If the compression algorithm changes in the feature, the default value may
not be 6. But if we use `DEFAULT_COMPRESSION`, it will still be equivalent to
the new default value. So I suggest we still use `Deflater.DEFAULT_COMPRESSION`
instead of any specific number.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
