Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/21848
@gatorsmile this can remove some of the expensive condition expressions, so
I would like to find a way to properly implement this.
Thank you all for chiming in with many good points. Let me summary here.
1. The cond expression can only be removed when it doesn't have a side
effect.
2. Stateful expression must have a side effect.
3. Some of the non-stateful expressions such as AssertTrue have a side
effect.
4. Determinstic expression could have a side effect.
5. Nondeterministic expressions always have a side effect.
This means `determinstic` is not enough, and we need another variable to
check if an expression has a side effect.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
