Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/21835#discussion_r204633464
--- Diff: R/pkg/tests/fulltests/test_context.R ---
@@ -21,10 +21,11 @@ test_that("Check masked functions", {
# Check that we are not masking any new function from base, stats,
testthat unexpectedly
# NOTE: We should avoid adding entries to *namesOfMaskedCompletely* as
masked functions make it
# hard for users to use base R functions. Please check when in doubt.
- namesOfMaskedCompletely <- c("cov", "filter", "sample", "not")
+ namesOfMaskedCompletely <- c("cov", "filter", "sample", "not",
"sequence")
--- End diff --
yes, we should definitely try to avoid adding here (as in the comment
above) unless we absolutely have to.
in this case, base::sequence can be commonly used - we really need a way to
avoid breaking it.
for example, could you try setting the generic as such:
`setGeneric("sequence", function(...) { standardGeneric("sequence") })`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
