Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/3094#discussion_r19857572
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/configuration/Strategy.scala
---
@@ -70,7 +70,7 @@ import
org.apache.spark.mllib.tree.configuration.QuantileStrategy._
*/
@Experimental
class Strategy (
--- End diff --
Note on binary compatibility: If we add new parameters later, it will
change the constructor signature. Then we need to provide auxiliary
constructors to maintain binary compatibility, which makes the code hard to
maintain in the long run. We can hide constructors with parameters and only
expose the one without any parameters. Then check the required parameters at
runtime by adding `def validate()`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
