Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21850#discussion_r204851642
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/SimplifyConditionalSuite.scala
---
@@ -61,7 +61,17 @@ class SimplifyConditionalSuite extends PlanTest with
PredicateHelper {
// i.e. removing branches whose conditions are always false
assertEquivalent(
CaseWhen(unreachableBranch :: normalBranch :: unreachableBranch ::
nullBranch :: Nil, None),
- CaseWhen(normalBranch :: Nil, None))
+ If(normalBranch._1, normalBranch._2, Literal(null,
normalBranch._2.dataType)))
--- End diff --
Can we add an extra branch into this test, so it won't be optimized to
single branch CaseWhen? Otherwise this test is changed from its original
purpose.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
