Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21752#discussion_r204885925
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala ---
    @@ -717,4 +717,9 @@ class DataFrameAggregateSuite extends QueryTest with 
SharedSQLContext {
           Row(1, 2, 1) :: Row(2, 2, 2) :: Row(3, 2, 3) :: Nil)
       }
     
    +  test("SPARK-24788: toString with unresolved expressions should not 
throw") {
    +    // these should not raise exceptions
    +    testData.groupBy('key).toString
    +    testData.groupBy(col("key")).toString
    --- End diff --
    
    add assert to compare the results. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to