Github user srowen commented on the pull request:

    https://github.com/apache/spark/pull/3103#issuecomment-61782743
  
    @liancheng the MANIFEST.MF is not copied from any particular place, but is 
merged from all dependency manifests. This is good for libraries that need some 
custom property to be preserved, although I'm not aware of a particular example 
of that. 
    
    The problem is that common properties like this collide and we end up with 
some arbitrary value from an arbitrary dependency. The manifest is still 
'proper' but some values aren't helpful. Yes they should be blanked out or set 
to something Spark-specific.
    
    The Maven build can easily discard all of these values like SBT. I'm not 
suggesting no MANIFEST.MF.
    
    But, I still don't see how this can help Beeline. This PR sets values that 
are definitely wrong for it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to