Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/3099#issuecomment-61785223
@mengxr Yes I agree with your conclusion. With a generic get/set by key
method, I suppose you don't strictly need all the particular getters and
setters. I suppose that's simpler, and if there's just one way to do it,
there's no confusion about key vs getter/setter. I don't know if you want to
remove the getters/setters entirely, but it wouldn't be crazy.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
