Github user dbtsai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21852#discussion_r205305691
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/SimplifyConditionalSuite.scala
 ---
    @@ -122,4 +126,25 @@ class SimplifyConditionalSuite extends PlanTest with 
PredicateHelper {
             None),
           CaseWhen(normalBranch :: trueBranch :: Nil, None))
       }
    +
    +  test("remove entire CaseWhen if all the outputs are semantic 
equivalence") {
    --- End diff --
    
    Yes, I plan to add couple more tests tonight.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to