Github user selvinsource commented on the pull request:
https://github.com/apache/spark/pull/3062#issuecomment-61792414
@srowen I added a wrapper called ModelExporter and changed everything else
to private[mllib], therefore this should be the only object exposed in the API.
I also separated, as you suggested, the model export hierarchy from the
serialization (which is now in the helper ModelExporter).
The usage is now even simpler
`ModelExporter.toPMML(kmeansModel,"/tmp/kmeans.xml")`
or any stream supported by the StreamResult
`ModelExporter.toPMML(kmeansModel,new StreamResult(System.out))`
I also committed some other changes based on your other comments above
(added the pmml version, ordered the imports, change the copyright to Apache
Spark MLlib).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
