GitHub user HyukjinKwon opened a pull request:

    https://github.com/apache/spark/pull/21880

    [SPARK-24929][INFRA] Make merge script don't swallow KeyboardInterrupt

    ## What changes were proposed in this pull request?
    
    If you want to get out of the loop to assign JIRA's user by command+c 
(KeyboardInterrupt), I am unable to get out. I faced this problem when the user 
doesn't have a contributor role and I just wanted to manually cancel and take 
an action to the JIRA.
    
    **Before:**
    
    ```
    Error assigning JIRA, try again (or leave blank and fix manually)
    JIRA is unassigned, choose assignee
    [0] todd.chen (Reporter)
    Enter number of user, or userid,  to assign to (blank to leave 
unassigned):Traceback (most recent call last):
      File "./dev/merge_spark_pr.py", line 322, in choose_jira_assignee
        "Enter number of user, or userid,  to assign to (blank to leave 
unassigned):")
    KeyboardInterrupt
    Error assigning JIRA, try again (or leave blank and fix manually)
    JIRA is unassigned, choose assignee
    [0] todd.chen (Reporter)
    Enter number of user, or userid,  to assign to (blank to leave 
unassigned):Traceback (most recent call last):
      File "./dev/merge_spark_pr.py", line 322, in choose_jira_assignee
        "Enter number of user, or userid,  to assign to (blank to leave 
unassigned):")
    KeyboardInterrupt
    ```
    
    
    **After:**
    
    ```
    Enter number of user, or userid,  to assign to (blank to leave 
unassigned):Traceback (most recent call last):
      File "./dev/merge_spark_pr.py", line 322, in choose_jira_assignee
        "Enter number of user, or userid to assign to (blank to leave 
unassigned):")
    KeyboardInterrupt
    Restoring head pointer to master
    git checkout master
    Already on 'master'
    git branch
    ```
    
    
    ## How was this patch tested?
    
    I made my own merging script with few fixes. I tested this manually.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HyukjinKwon/spark key-error

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/21880.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21880
    
----
commit e87c2680e505153beb6724347356293c5250a029
Author: hyukjinkwon <gurwls223@...>
Date:   2018-07-26T08:24:03Z

    Make merge script don't swallow KeyboardInterrupt

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to