Github user gengliangwang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21873#discussion_r205374847
  
    --- Diff: scalastyle-config.xml ---
    @@ -150,6 +150,19 @@ This file is divided into 3 sections:
           // scalastyle:on println]]></customMessage>
       </check>
     
    +  <check customId="hadoopconfiguration" level="error" 
class="org.scalastyle.file.RegexChecker" enabled="true">
    +    <parameters><parameter 
name="regex">spark(.sqlContext)?.sparkContext.hadoopConfiguration</parameter></parameters>
    --- End diff --
    
    Even with such loose policy, we have to wrap code block with "// 
scalastyle:off hadoopconfiguration" in some test cases for setting the hadoop 
conf.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to