Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21880#discussion_r205474983
--- Diff: dev/merge_spark_pr.py ---
@@ -331,6 +331,9 @@ def choose_jira_assignee(issue, asf_jira):
assignee = asf_jira.user(raw_assignee)
asf_jira.assign_issue(issue.key, assignee.key)
return assignee
+ except KeyboardInterrupt:
+ traceback.print_exc()
+ sys.exit(-1)
--- End diff --
nope. I don't have a special reason for it - just found that's used in this
script and thought it's better to make sure exiting. The root exception
handling already catches all the exceptions and looks the exception is being
handled for now.
But yup let me change and test it in other PRs or this PR :-). not a big
deal.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
