Github user culler commented on the pull request:
https://github.com/apache/spark/pull/3066#issuecomment-61830155
Thanks @liancheng. I deleted the comment to avoid wasting your time since
I figured out what was going on.
Actually it was not my test suite that i was worried about. Many existing
tests would not compile because my new conversions add an === operator to
types such as Int when the new conversions are in scope, as they are when
testing the DSL. I followed scalatest's advice for dealing with cases
where an === operator already exists. Namely, to apply their conversion
explicitly:
assert(X === Y) --> assert(convertToEqualizer(X).===(Y))
Will that be OK? (I import convertToEqualizer as EQ for brevity.)
I wanted to pass the existing tests before adding any new ones. I am
checking that now. It looks good so far, but unfortunately, 11 test files
had to be edited as above.
On Tue, Nov 4, 2014 at 11:31 PM, Cheng Lian <[email protected]>
wrote:
> Hey @culler <https://github.com/culler>, saw you comment about testing
> yesterday (gone now?) but didn't have time to response. Yes, the ===
> operator is used by in both Spark SQL DSL and ScalaTest. To workaround
> this, you can either add your test case in DslQuerySuite and use
> checkAnswer for assertion, or simply avoid to use ===, there're some
> other assertion functions in ScalaTest, for example, assertResult is one
> of my favorite :)
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/spark/pull/3066#issuecomment-61761929>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
