Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21822#discussion_r205674265
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
 ---
    @@ -787,6 +782,7 @@ class Analyzer(
               right
             case Some((oldRelation, newRelation)) =>
               val attributeRewrites = 
AttributeMap(oldRelation.output.zip(newRelation.output))
    +          // TODO(rxin): Why do we need transformUp here?
    --- End diff --
    
    we still need to transform resolved plan here to resolve self-join. Image
    ```
    val df = ...
    df.as("a").join(df.as("b"), ...)
    ```
    We need to look into the resolved plan to replace the conflicted attributes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to