Github user cclauss commented on a diff in the pull request:
https://github.com/apache/spark/pull/20838#discussion_r205870627
--- Diff: dev/create-release/releaseutils.py ---
@@ -149,7 +152,11 @@ def get_commits(tag):
if not is_valid_author(author):
author = github_username
# Guard against special characters
- author = unidecode.unidecode(unicode(author, "UTF-8")).strip()
+ try: # Python 2
+ author = unicode(author, "UTF-8")
+ except NameError: # Python 3
+ author = str(author)
+ author = unidecode.unidecode(author).strip()
--- End diff --
> The way it is now [...] it's probably safer.
Let's agree to leave this as is in this PR. EOL of Python 2 in 500 daze
away so safe is better.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
