Github user heary-cao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21860#discussion_r205943335
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
 ---
    @@ -232,6 +232,22 @@ class WholeStageCodegenSuite extends QueryTest with 
SharedSQLContext {
         }
       }
     
    +  ignore("SPARK-24901 check merge FastHashMap and RegularHashMap generate 
code max size") {
    --- End diff --
    
    The result of this test case is correct and the running time is very short. 
But I'm not sure if need to open this use case, because I see that other unit 
test cases of testing CodeGen's maxCodesize are closed. thanks.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to