Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21886#discussion_r205980691
  
    --- Diff: 
sql/core/src/test/resources/sql-tests/results/intersect-all.sql.out ---
    @@ -0,0 +1,236 @@
    +-- Automatically generated by SQLQueryTestSuite
    +-- Number of queries: 17
    +
    +
    +-- !query 0
    +CREATE TEMPORARY VIEW tab1 AS SELECT * FROM VALUES
    +    (1, 2), 
    +    (1, 2),
    +    (1, 3),
    +    (1, 3),
    +    (2, 3),
    +    (null, null),
    +    (null, null)
    +    AS tab1(k, v)
    +-- !query 0 schema
    +struct<>
    +-- !query 0 output
    +
    +
    +
    +-- !query 1
    +CREATE TEMPORARY VIEW tab2 AS SELECT * FROM VALUES
    +    (1, 2), 
    +    (1, 2), 
    +    (2, 3),
    +    (3, 4),
    +    (null, null),
    +    (null, null)
    +    AS tab2(k, v)
    +-- !query 1 schema
    +struct<>
    +-- !query 1 output
    +
    +
    +
    +-- !query 2
    +SELECT * FROM tab1
    +INTERSECT ALL
    +SELECT * FROM tab2
    +-- !query 2 schema
    +struct<k:int,v:int>
    +-- !query 2 output
    +1  2
    +1  2
    +2  3
    +NULL       NULL
    +NULL       NULL
    +
    +
    +-- !query 3
    +SELECT * FROM tab1
    +INTERSECT ALL
    +SELECT * FROM tab1 WHERE k = 1
    +-- !query 3 schema
    +struct<k:int,v:int>
    +-- !query 3 output
    +1  2
    +1  2
    +1  3
    +1  3
    +
    +
    +-- !query 4
    +SELECT * FROM tab1 WHERE k > 2
    +INTERSECT ALL
    +SELECT * FROM tab2
    +-- !query 4 schema
    +struct<k:int,v:int>
    +-- !query 4 output
    +
    +
    +
    +-- !query 5
    +SELECT * FROM tab1
    +INTERSECT ALL
    +SELECT * FROM tab2 WHERE k > 3
    +-- !query 5 schema
    +struct<k:int,v:int>
    +-- !query 5 output
    +
    +
    +
    +-- !query 6
    +SELECT * FROM tab1
    +INTERSECT ALL
    +SELECT CAST(1 AS BIGINT), CAST(2 AS BIGINT)
    +-- !query 6 schema
    +struct<k:bigint,v:bigint>
    +-- !query 6 output
    +1  2
    +
    +
    +-- !query 7
    +SELECT * FROM tab1
    +INTERSECT ALL
    +SELECT array(1), 2
    +-- !query 7 schema
    +struct<>
    +-- !query 7 output
    +org.apache.spark.sql.AnalysisException
    +IntersectAll can only be performed on tables with the compatible column 
types. array<int> <> int at the first column of the second table;
    +
    +
    +-- !query 8
    +SELECT k FROM tab1
    +INTERSECT ALL
    +SELECT k, v FROM tab2
    +-- !query 8 schema
    +struct<>
    +-- !query 8 output
    +org.apache.spark.sql.AnalysisException
    +IntersectAll can only be performed on tables with the same number of 
columns, but the first table has 1 columns and the second table has 2 columns;
    +
    +
    +-- !query 9
    +SELECT * FROM tab2
    +INTERSECT ALL
    +SELECT * FROM tab1
    +INTERSECT ALL
    +SELECT * FROM tab2
    +-- !query 9 schema
    +struct<k:int,v:int>
    +-- !query 9 output
    +1  2
    +1  2
    +2  3
    +NULL       NULL
    +NULL       NULL
    +
    +
    +-- !query 10
    +SELECT * FROM tab1
    +EXCEPT
    +SELECT * FROM tab2
    +UNION ALL
    +SELECT * FROM tab1
    +INTERSECT ALL
    +SELECT * FROM tab2
    +-- !query 10 schema
    +struct<k:int,v:int>
    +-- !query 10 output
    +1  2
    +1  2
    +2  3
    +NULL       NULL
    +NULL       NULL
    --- End diff --
    
    This misses one row (1, 3). Could you investigate the cause?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to