Github user mauropalsgraaf commented on a diff in the pull request:
https://github.com/apache/spark/pull/21807#discussion_r206142897
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -68,9 +68,18 @@ trait CheckAnalysis extends PredicateHelper {
case e if e.dataType != IntegerType => failAnalysis(
s"The limit expression must be integer type, but got " +
e.dataType.catalogString)
- case e if e.eval().asInstanceOf[Int] < 0 => failAnalysis(
--- End diff --
I'm personally not a fan of this because of the nesting, but I guess it's a
matter of taste. Is there any guidelines for this regarding to styling? I don't
have a strong opinion about this
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
