Github user dbtsai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21904#discussion_r206333426
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
 ---
    @@ -416,6 +450,12 @@ object SimplifyConditionals extends Rule[LogicalPlan] 
with PredicateHelper {
             // these branches can be pruned away
             val (h, t) = branches.span(_._1 != TrueLiteral)
             CaseWhen( h :+ t.head, None)
    +
    +      case e @ CaseWhen(branches, _) if 
pruneSeenBranches(branches).nonEmpty =>
    +        e.copy(branches = pruneSeenBranches(branches).get)
    +
    +      case e @ CaseWhen(branches, _) if 
combineAdjacentBranches(branches).nonEmpty =>
    +        e.copy(branches = combineAdjacentBranches(branches).get)
    --- End diff --
    
    This will work. But my only concern is that this will be caught all the 
`CaseWhen` cases; as a result, no more rule can be added after this.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to