Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/3101#discussion_r19918492
--- Diff:
network/common/src/main/java/org/apache/spark/network/protocol/MessageEncoder.java
---
@@ -66,7 +66,7 @@ public void encode(ChannelHandlerContext ctx, Message in,
List<Object> out) {
// All messages have the frame length, message type, and message
itself.
int headerLength = 8 + msgType.encodedLength() + in.encodedLength();
long frameLength = headerLength + bodyLength;
- ByteBuf header = ctx.alloc().buffer(headerLength);
+ ByteBuf header = ctx.alloc().heapBuffer(headerLength);
--- End diff --
The header is a very small buffer, I thought it was overkill to try to get
direct byte bufs for it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
