Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/21930#discussion_r206540368
--- Diff: core/src/main/scala/org/apache/spark/TaskContext.scala ---
@@ -123,7 +123,7 @@ abstract class TaskContext extends Serializable {
*
* Exceptions thrown by the listener will result in failure of the task.
*/
- def addTaskCompletionListener(f: (TaskContext) => Unit): TaskContext = {
+ def addTaskCompletionListener[U](f: (TaskContext) => U): TaskContext = {
--- End diff --
Do we need to change this? I don't think it is a problem binary
compatibility wise, but it seems a but weird since we don't use the result of
the function.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
