Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r206702526
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -308,10 +319,10 @@ object GenerateUnsafeProjection extends
CodeGenerator[Seq[Expression], UnsafePro
expressions: Seq[Expression],
useSubexprElimination: Boolean = false): ExprCode = {
val exprEvals = ctx.generateExpressions(expressions,
useSubexprElimination)
- val exprTypes = expressions.map(_.dataType)
+ val exprTypeAndNullables = expressions.map(e => (e.dataType,
e.nullable))
- val numVarLenFields = exprTypes.count {
- case dt if UnsafeRow.isFixedLength(dt) => false
+ val numVarLenFields = exprTypeAndNullables.count {
+ case (dt, _) if UnsafeRow.isFixedLength(dt) => false
--- End diff --
is `.count { case (dt, _) => !UnsafeRow.isFixedLength(dt) }` more
straightforward?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
