Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21305#discussion_r206748200
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/WriteSupport.java ---
@@ -38,15 +38,16 @@
* If this method fails (by throwing an exception), the action will fail
and no Spark job will be
* submitted.
*
- * @param jobId A unique string for the writing job. It's possible that
there are many writing
- * jobs running at the same time, and the returned {@link
DataSourceWriter} can
- * use this job id to distinguish itself from other jobs.
+ * @param writeUUID A unique string for the writing job. It's possible
that there are many writing
+ * jobs running at the same time, and the returned
{@link DataSourceWriter} can
+ * use this job id to distinguish itself from other
jobs.
* @param schema the schema of the data to be written.
* @param mode the save mode which determines what to do when the data
are already in this data
* source, please refer to {@link SaveMode} for more details.
* @param options the options for the returned data source writer, which
is an immutable
* case-insensitive string-to-string map.
+ * @return a writer to append data to this data source
--- End diff --
non-append cases also call this `createWriter`, shall we remove this line?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
