Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/21921#discussion_r206946076
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/continuous/ContinuousRateStreamSource.scala
---
@@ -91,7 +90,7 @@ class RateStreamContinuousReader(options:
DataSourceOptions)
i,
numPartitions,
perPartitionRate)
- .asInstanceOf[InputPartition[Row]]
+ .asInstanceOf[InputPartition[InternalRow]]
--- End diff --
I don't think it's a good idea to leave casts. Can you check to see if this
can be avoided? I found in #21118 that many of the casts were unnecessary if
variables had declared types and it is much better to avoid explicit casts that
work around the type system.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
