Github user skambha commented on a diff in the pull request:
https://github.com/apache/spark/pull/17185#discussion_r206988504
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
---
@@ -120,22 +120,54 @@ abstract class LogicalPlan
/**
* Resolve the given `name` string against the given attribute,
returning either 0 or 1 match.
--- End diff --
At a high level the changes include:
* The column resolution needs to account for the qualifier that is now a
sequence of string.
* Enhance the lookupRelation to add the qualifier appropriately. Right now,
the qualifier used by the LogicalPlan nodes representing the relation leafnodes
use only the table name as the qualifier when no alias is provided. This needs
to be updated to add the database name and the table name for permanent views
and tables and global temporary views.
â¨Full details of the design and the resolution logic is in the [doc
here](https://drive.google.com/file/d/1zKm3aNZ3DpsqIuoMvRsf0kkDkXsAasxH/view)
in Section 3.3 and 3.4.
So, Section 2 in the design doc has a lot of scenarios that were tested
against different dbâs and Spark and the expected behavior with the design
here.
If there is a specific scenario you have in mind that would be valid but
get flagged as ambiguous, can you please let me know. Iâd be glad to look
into it.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
