Github user skonto commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21930#discussion_r207009085
  
    --- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
    @@ -218,118 +261,132 @@ private[spark] object ClosureCleaner extends 
Logging {
           return
         }
     
    -    logDebug(s"+++ Cleaning closure $func (${func.getClass.getName}) +++")
    -
    -    // A list of classes that represents closures enclosed in the given one
    -    val innerClasses = getInnerClosureClasses(func)
    -
    -    // A list of enclosing objects and their respective classes, from 
innermost to outermost
    -    // An outer object at a given index is of type outer class at the same 
index
    -    val (outerClasses, outerObjects) = getOuterClassesAndObjects(func)
    -
    -    // For logging purposes only
    -    val declaredFields = func.getClass.getDeclaredFields
    -    val declaredMethods = func.getClass.getDeclaredMethods
    -
    -    if (log.isDebugEnabled) {
    -      logDebug(" + declared fields: " + declaredFields.size)
    -      declaredFields.foreach { f => logDebug("     " + f) }
    -      logDebug(" + declared methods: " + declaredMethods.size)
    -      declaredMethods.foreach { m => logDebug("     " + m) }
    -      logDebug(" + inner classes: " + innerClasses.size)
    -      innerClasses.foreach { c => logDebug("     " + c.getName) }
    -      logDebug(" + outer classes: " + outerClasses.size)
    -      outerClasses.foreach { c => logDebug("     " + c.getName) }
    -      logDebug(" + outer objects: " + outerObjects.size)
    -      outerObjects.foreach { o => logDebug("     " + o) }
    -    }
    +    if(lambdaFunc.isEmpty) {
    +      logDebug(s"+++ Cleaning closure $func (${func.getClass.getName}) 
+++")
    +
    +      // A list of classes that represents closures enclosed in the given 
one
    +      val innerClasses = getInnerClosureClasses(func)
    +
    +      // A list of enclosing objects and their respective classes, from 
innermost to outermost
    +      // An outer object at a given index is of type outer class at the 
same index
    +      val (outerClasses, outerObjects) = getOuterClassesAndObjects(func)
    +
    +      // For logging purposes only
    +      val declaredFields = func.getClass.getDeclaredFields
    +      val declaredMethods = func.getClass.getDeclaredMethods
    +
    +      if (log.isDebugEnabled) {
    +        logDebug(" + declared fields: " + declaredFields.size)
    --- End diff --
    
    This stuff pre-existed.  The git diff just shows them again because I added 
that if statement at the top.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to