Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21236#discussion_r207078480
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -98,6 +98,9 @@ trait ExpressionEvalHelper extends
GeneratorDrivenPropertyChecks {
if (expected.isNaN) result.isNaN else expected == result
case (result: Float, expected: Float) =>
if (expected.isNaN) result.isNaN else expected == result
+ case (result: UnsafeRow, expected: GenericInternalRow) =>
--- End diff --
@mn-mikke I was just looking over compiler warnings, and noticed it claims
this case is never triggered. I think it's because it would always first match
the (InternalRow, InternalRow) case above. Should it go before that then?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
