Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2984#issuecomment-61930885
Hey I took a look at this and had a few observations. This example is
actually a bit different from what we were trying to do with Gauva, so it's not
possible to directly pattern match - I might have lead @mccheah astray slightly
with that advice.
1. This spends a lot of effort to make jetty "provided" and then escalate
it to compile scope. I think this can all be removed in favor of just leaving
at at compile scope. Since we publish effective poms now, jetty will simply be
removed from the pom that is published (it won't have any scope since it won't
be present as a dependency). That can remove a lot of code.
2. This approach doesn't actually relocate the jetty classes, it just
inlines them in the spark-core jar. This won't help people who have dependency
conflicts with jetty.
```
> jar -tf spark-core_2.10-1.2.0-SNAPSHOT.jar |grep jetty | head -n 10
org/eclipse/jetty/
org/eclipse/jetty/plus/
org/eclipse/jetty/plus/servlet/
org/eclipse/jetty/plus/servlet/ServletHandler.class
org/eclipse/jetty/plus/webapp/
org/eclipse/jetty/plus/webapp/PlusDescriptorProcessor$1.class
org/eclipse/jetty/plus/webapp/PlusDescriptorProcessor.class
org/eclipse/jetty/plus/webapp/PlusDecorator.class
org/eclipse/jetty/plus/webapp/PlusConfiguration.class
org/eclipse/jetty/plus/webapp/EnvConfiguration$1.class
```
I'll see if I can send a patch that does this in a different way. We can
then use that as the example for any future things we shade.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
