Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21935#discussion_r207119879
  
    --- Diff: 
external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala ---
    @@ -41,6 +41,7 @@ import org.apache.spark.sql.types._
     class AvroSuite extends QueryTest with SharedSQLContext with SQLTestUtils {
       val episodesAvro = testFile("episodes.avro")
       val testAvro = testFile("test.avro")
    +  val timestampAvro = testFile("timestamp.avro")
    --- End diff --
    
    at least we should provide how the binary file is generated, or just do 
roundtrip test: Spark write avro files and then read it.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to