Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21895#discussion_r207136738
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -80,8 +80,8 @@ import org.apache.spark.util.kvstore._
* break. Simple streaming of JSON-formatted events, as is implemented
today, implicitly
* maintains this invariant.
*/
-private[history] class FsHistoryProvider(conf: SparkConf, clock: Clock)
- extends ApplicationHistoryProvider with Logging {
+private[history] class FsHistoryProvider(conf: SparkConf, protected val
clock: Clock)
+ extends ApplicationHistoryProvider with LogFilesBlacklisting with
Logging {
--- End diff --
I just wanted to separate the blacklisting logic since `FsHistoryProvider`
contains already a lot of code. So I just considered it more readable. If you
prefer I can inline it.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
