Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21911
Generally, it looks good to me. Let us target this to the upcoming 2.4
release
We need to improve the test coverage:
- Add a test case when users specify multiple REPARTITION, COALESCE hints
`... INSERT INTO s SELECT /*+ REPARTITION(100), COALESCE(500), COALESCE(10) */
* FROM t ...`
- Add a test case when users specify BROADCAST and REPARTITION hints at the
same time
- Add an end-to-end test case.
- Add a unit test case in ResolveHintsSuite.scala to verify the hint names
are case insensitive.
- Add more negative test cases. For example, `"SELECT /*+ COALESCE(1.0) */
* FROM t"` and `"SELECT /*+ COALESCE(3 + 4) */ * FROM t"`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
