Github user ijuma commented on a diff in the pull request:
https://github.com/apache/spark/pull/21955#discussion_r207317252
--- Diff:
external/kafka-0-10/src/test/scala/org/apache/spark/streaming/kafka010/KafkaRDDSuite.scala
---
@@ -72,31 +72,37 @@ class KafkaRDDSuite extends SparkFunSuite with
BeforeAndAfterAll {
private def compactLogs(topic: String, partition: Int, messages:
Array[(String, String)]) {
val mockTime = new MockTime()
- // LogCleaner in 0.10 version of Kafka is still expecting the old
TopicAndPartition api
- val logs = new Pool[TopicAndPartition, Log]()
+ val logs = new Pool[TopicPartition, Log]()
val logDir = kafkaTestUtils.brokerLogDir
val dir = new File(logDir, topic + "-" + partition)
dir.mkdirs()
val logProps = new ju.Properties()
logProps.put(LogConfig.CleanupPolicyProp, LogConfig.Compact)
logProps.put(LogConfig.MinCleanableDirtyRatioProp,
java.lang.Float.valueOf(0.1f))
+ // TODO is this new Log declaration correct?
+ val logDirFailureChannel = new LogDirFailureChannel(0)
--- End diff --
This should be `1` if we're assuming a single log directory.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
