Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/21809#discussion_r207327804
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala ---
@@ -105,15 +105,29 @@ private[ui] class StagePage(parent: StagesTab, store:
AppStatusStore) extends We
val stageAttemptId = parameterAttempt.toInt
val stageHeader = s"Details for Stage $stageId (Attempt
$stageAttemptId)"
- val stageData = parent.store
- .asOption(parent.store.stageAttempt(stageId, stageAttemptId, details
= false))
- .getOrElse {
+ var stageDataTuple: Tuple2[StageData, Seq[Int]] = null
+ try {
--- End diff --
I think you could use options here instead of try and null checks to make
this cleaner
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
