Github user ifilonenko commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21584#discussion_r207382976
  
    --- Diff: 
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/bindings/R/Dockerfile
 ---
    @@ -0,0 +1,29 @@
    +#
    +# Licensed to the Apache Software Foundation (ASF) under one or more
    +# contributor license agreements.  See the NOTICE file distributed with
    +# this work for additional information regarding copyright ownership.
    +# The ASF licenses this file to You under the Apache License, Version 2.0
    +# (the "License"); you may not use this file except in compliance with
    +# the License.  You may obtain a copy of the License at
    +#
    +#    http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing, software
    +# distributed under the License is distributed on an "AS IS" BASIS,
    +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +# See the License for the specific language governing permissions and
    +# limitations under the License.
    +#
    +
    +ARG base_img
    +FROM $base_img
    +WORKDIR /
    +RUN mkdir ${SPARK_HOME}/R
    +COPY R ${SPARK_HOME}/R
    +
    +RUN apk add --no-cache R R-dev
    --- End diff --
    
    Agreed. Minor versions are something we *might* want to support in the 
future. Let's look to include this in a follow-up PR if there is enough desire 
in custom version arguments to be passed as build_args to the 
`bin/docker-image-tool.sh` 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to