Github user aarondav commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3142#discussion_r19964950
  
    --- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala ---
    @@ -343,15 +343,7 @@ private[spark] class SecurityManager(sparkConf: 
SparkConf) extends Logging with
        */
       def getSecretKey(): String = secretKey
     
    -  override def getSaslUser(appId: String): String = {
    -    val myAppId = sparkConf.getAppId
    -    require(appId == myAppId, s"SASL appId $appId did not match my appId 
${myAppId}")
    -    getSaslUser()
    -  }
    -
    -  override def getSecretKey(appId: String): String = {
    -    val myAppId = sparkConf.getAppId
    -    require(appId == myAppId, s"SASL appId $appId did not match my appId 
${myAppId}")
    -    getSecretKey()
    -  }
    +  // Default SecurityManager only has a single secret key, so ignore appId.
    --- End diff --
    
    I realized that these checks were not useful (since the secret key is 
already doing the security checks). Additionally, it doesn't make sense on the 
Worker.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to