Github user rdblue commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21305#discussion_r207623469
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
 ---
    @@ -352,6 +351,36 @@ case class Join(
       }
     }
     
    +/**
    + * Append data to an existing table.
    + */
    +case class AppendData(
    +    table: NamedRelation,
    +    query: LogicalPlan,
    +    isByName: Boolean) extends LogicalPlan {
    +  override def children: Seq[LogicalPlan] = Seq(query)
    +  override def output: Seq[Attribute] = Seq.empty
    +
    +  override lazy val resolved: Boolean = {
    +    query.output.size == table.output.size && 
query.output.zip(table.output).forall {
    +      case (inAttr, outAttr) =>
    +          inAttr.name == outAttr.name &&                // names must match
    +          outAttr.dataType.sameType(inAttr.dataType) && // types must match
    --- End diff --
    
    Good catch, I agree.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to