Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17185#discussion_r207702706
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalogSuite.scala
 ---
    @@ -536,12 +536,13 @@ abstract class SessionCatalogSuite extends 
AnalysisTest {
           assert(metadata.viewText.isDefined)
           val view = View(desc = metadata, output = 
metadata.schema.toAttributes,
             child = CatalystSqlParser.parsePlan(metadata.viewText.get))
    +      val alias = AliasIdentifier("view1", Some("db3"))
    --- End diff --
    
    instead of creating `AliasIdentifier` manually, we can also define a 
`SubqueryAlias.apply` which takes db name and table name.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to