Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21898#discussion_r207743781
--- Diff: core/src/main/scala/org/apache/spark/BarrierTaskContext.scala ---
@@ -80,7 +101,45 @@ class BarrierTaskContext(
@Experimental
@Since("2.4.0")
def barrier(): Unit = {
- // TODO SPARK-24817 implement global barrier.
+ val callSite = Utils.getCallSite()
+ logInfo(s"Task $taskAttemptId from Stage $stageId(Attempt
$stageAttemptNumber) has entered " +
+ s"the global sync, current barrier epoch is $barrierEpoch.")
+ logTrace(s"Current callSite: $callSite")
--- End diff --
How about the following since `Utils.getCallSite()` is not lightweight?
```
if (isTraceEnabled) {
val callSite = Utils.getCallSite()
logTrace(s"Current callSite: $callSite")
}
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
