Github user devaraj-kavali commented on a diff in the pull request:
https://github.com/apache/spark/pull/21996#discussion_r207763630
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -98,17 +98,24 @@ private[spark] class SparkSubmit extends Logging {
* Kill an existing submission using the REST protocol. Standalone and
Mesos cluster mode only.
*/
private def kill(args: SparkSubmitArguments): Unit = {
- new RestSubmissionClient(args.master)
- .killSubmission(args.submissionToKill)
+ createRestSubmissionClient(args).killSubmission(args.submissionToKill)
}
/**
* Request the status of an existing submission using the REST protocol.
* Standalone and Mesos cluster mode only.
*/
private def requestStatus(args: SparkSubmitArguments): Unit = {
- new RestSubmissionClient(args.master)
- .requestSubmissionStatus(args.submissionToRequestStatusFor)
+
createRestSubmissionClient(args).requestSubmissionStatus(args.submissionToRequestStatusFor)
+ }
+
+ /**
+ * Creates RestSubmissionClient with overridden logInfo()
+ */
+ private def createRestSubmissionClient(args: SparkSubmitArguments):
RestSubmissionClient = {
+ new RestSubmissionClient(args.master) {
+ override protected def logInfo(msg: => String): Unit =
printMessage(msg)
--- End diff --
I agree, user can change this log level. If the users configure the log
level as WARN or above(WARN is the default log level) then they can't see any
update/status from status and kill commands. I think we cannot expect the user
to configure the log level to INFO if they want to run status and kill commands
with status/update. Please let me know if you have any thoughts to fix this
better, I can make the changes. Thanks
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
