Github user jose-torres commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21919#discussion_r207961663
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2.scala
 ---
    @@ -179,3 +192,24 @@ class InternalRowDataWriter(rowWriter: 
DataWriter[Row], encoder: ExpressionEncod
     
       override def abort(): Unit = rowWriter.abort()
     }
    +
    +/**
    + * Collects commit progress on writers.
    +*/
    +trait StreamWriterProgressCollector {
    --- End diff --
    
    This is a kinda weird interface. Can't we just create a 
StreamWriterCommitProgress(numOutputRows) instead of round-tripping through 
here?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to