GitHub user mgaido91 opened a pull request: https://github.com/apache/spark/pull/22021
[SPARK-24948][SHS] Delegate check access permissions to the file system ## What changes were proposed in this pull request? In `SparkHadoopUtil. checkAccessPermission`, we consider only basic permissions in order to check whether a user can access a file or not. This is not a complete check, as it ignores ACLs and other policies a file system may apply in its internal. So this can result in returning wrongly that a user cannot access a file (despite he actually can). The PR proposes to delegate to the filesystem the check whether a file is accessible or not, in order to return the right result. A caching layer is added for performance reasons. ## How was this patch tested? added UT You can merge this pull request into a Git repository by running: $ git pull https://github.com/mgaido91/spark SPARK-24948_2.3 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/22021.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #22021 ---- commit aed77f3bdf6e1ddacf95373932cb178fe7bf5eda Author: Marco Gaido <marcogaido91@...> Date: 2018-08-06T21:29:05Z [SPARK-24948][SHS] Delegate check access permissions to the file system In `SparkHadoopUtil. checkAccessPermission`, we consider only basic permissions in order to check wether a user can access a file or not. This is not a complete check, as it ignores ACLs and other policies a file system may apply in its internal. So this can result in returning wrongly that a user cannot access a file (despite he actually can). The PR proposes to delegate to the filesystem the check whether a file is accessible or not, in order to return the right result. A caching layer is added for performance reasons. modified UTs Author: Marco Gaido <marcogaid...@gmail.com> Closes #21895 from mgaido91/SPARK-24948. ---- --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org