Github user ifilonenko commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21669#discussion_r208257021
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
    @@ -336,7 +336,7 @@ private[spark] class SparkSubmit extends Logging {
         val targetDir = Utils.createTempDir()
     
         // assure a keytab is available from any place in a JVM
    -    if (clusterManager == YARN || clusterManager == LOCAL || 
isMesosClient) {
    +    if (clusterManager == YARN || clusterManager == LOCAL || isMesosClient 
|| isKubernetesCluster) {
    --- End diff --
    
    This check can be removed, but I included it since I believed that the 
keytab shouldn't be stored as a secret for security reasons and should instead 
be only accessible from the JVM. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to