Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22014#discussion_r208406147
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
 ---
    @@ -87,7 +87,7 @@ object GenerateUnsafeProjection extends 
CodeGenerator[Seq[Expression], UnsafePro
           // For top level row writer, it always writes to the beginning of 
the global buffer holder,
           // which means its fixed-size region always in the same position, so 
we don't need to call
           // `reset` to set up its fixed-size region every time.
    -      if (inputs.map(_.isNull).forall(_ == "false")) {
    --- End diff --
    
    @kiszk  was this intentional?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to