Github user gengliangwang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22037#discussion_r208660814
  
    --- Diff: 
external/avro/src/main/scala/org/apache/spark/sql/avro/SchemaConverters.scala 
---
    @@ -139,7 +142,16 @@ object SchemaConverters {
     
           case FloatType => builder.floatType()
           case DoubleType => builder.doubleType()
    -      case _: DecimalType | StringType => builder.stringType()
    +      case StringType => builder.stringType()
    +      case d: DecimalType =>
    +        val avroType = LogicalTypes.decimal(d.precision, d.scale)
    +        if (nullable) {
    +          val schema = 
avroType.addToSchema(SchemaBuilder.builder().bytesType())
    --- End diff --
    
    no, in the next line `builder` is nullable.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to