Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22039#discussion_r208666588
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
 ---
    @@ -273,6 +273,9 @@ class SymmetricHashJoinStateManager(
               s.copy(desc = newDesc(desc)) -> value
             case (s @ StateStoreCustomTimingMetric(_, desc), value) =>
               s.copy(desc = newDesc(desc)) -> value
    +        case (s, _) =>
    +          throw new IllegalArgumentException(
    +          s"Unknown state store custom metric is found at metrics: $s")
    --- End diff --
    
    nit: 2 more spaces?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to