GitHub user kiszk opened a pull request: https://github.com/apache/spark/pull/22044
[SPARK-23912][SQL][Followup] Refactor ArrayDistinct ## What changes were proposed in this pull request? This PR simplified code generation for `ArrayDistinct`. #21966 enabled code generation only if the type can be specialized by the hash set. This PR follows this strategy. Optimization of null handling will be implemented in #21912. ## How was this patch tested? Existing UTs You can merge this pull request into a Git repository by running: $ git pull https://github.com/kiszk/spark SPARK-23912-follow Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/22044.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #22044 ---- commit 9d0cb100a85dc77569e1a62b83e0461ee2c33ddb Author: Kazuaki Ishizaki <ishizaki@...> Date: 2018-08-08T18:43:51Z stop code generation when elementTypeSupportEquals is false ---- --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org