Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r208696353
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -70,7 +72,8 @@ object GenerateUnsafeProjection extends
CodeGenerator[Seq[Expression], UnsafePro
| // Remember the current cursor so that we can calculate how many
bytes are
| // written later.
| final int $previousCursor = $rowWriter.cursor();
- | ${writeExpressionsToBuffer(ctx, tmpInput, fieldEvals,
fieldTypes, structRowWriter)}
+ | ${writeExpressionsToBuffer(
--- End diff --
nit: in situations like this I have been told to move the function call
before and assign it to a variable
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
