Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21859#discussion_r208774474
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2799,6 +2799,26 @@ class SQLQuerySuite extends QueryTest with
SharedSQLContext {
}
}
+ test("SPARK-24900: speed up sort when the dataset is small") {
+ withTempView("src") {
+ // the optimization works
--- End diff --
It is hard to tell if this optimization actually works from this test. Can
we check if `getSampledArray` returns correct data?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
